Mailer with no implicit template #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -733,6 +733,7 @@ def collect_responses_and_parts_order(headers) #:nodoc: | |||
|
|
|||
| def each_template(paths, name, &block) #:nodoc: | |||
| templates = lookup_context.find_all(name, Array(paths)) | |||
| raise ActionView::MissingTemplate.new([paths], name, [paths], false, 'mailer') if templates.empty? | |||
There was a problem hiding this comment.
def each_template(paths, name, &block) #:nodoc:
templates = lookup_context.find_all(name, Array(paths))
if templates.empty?
raise ActionView::MissingTemplate.new([paths], name, [paths], false, 'mailer')
else
templates.uniq { |t| t.formats }.each(&block)
end
endIs not better to read?
There was a problem hiding this comment.
All right. I have updated it accordingly.
|
Please add a CHANGELOG entry |
|
I have made the code change you suggested and added the changelog entry. Thanks @rafaelfranca |
ghost
assigned 
rafaelfranca
added a commit
that referenced
this pull request
Jun 20, 2012
…mplate Mailer with no implicit template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we send an email and use the implicit template with it but not template exists, nothing fails.
I don't think that's the behavior usually intended.
This will raise an
ActionView::MissingTemplatein that case.It already occurs like this when rendering an explicit template.