Don't paramify ActionDispatch::Http::UploadedFile in tests #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a test for that, to ensure it won't break in future changes? Thanks. |
|
Could you squash the commits and add a description to commit message? Basically something similar to what you wrote in issue description (here is a few more words about that: http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#commit-your-changes) |
To test uploading a file without using fixture_file_upload, a posted ActionDispatch::Http::UploadedFile should not be paramified (just like Rack::Test::UploadedFile). (Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't share the same API, tempfile is not accessible on Rack::Test::UploadedFile as discussed in rack/rack-test#30)
carlosantoniodasilva
added a commit
that referenced
this pull request
Jun 23, 2012
Don't paramify ActionDispatch::Http::UploadedFile in tests
|
@tim-vandecasteele thanks! |
|
My pleasure, thanks for the great guidance towards my first commit. |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test uploading a file without using fixture_file_upload, a posted ActionDispatch::Http::UploadedFile should not be paramified (just like Rack::Test::UploadedFile).
(Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't share the same API, tempfile is not
accessible on Rack::Test::UploadedFile as discussed in rack/rack-test#30)