Fix wrong commits. I had mistakes. #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +157,7 @@ def test_db_test_prepare_when_using_sql_format | |||
| add_to_config "config.active_record.schema_format = :sql" | |||
| output = Dir.chdir(app_path) do | |||
| `rails generate scaffold user username:string; | |||
| bundle exec rake db:migrate db:test:clone 2>&1 --trace` | |||
| bundle exec rake db:migrate db:test:prepare 2>&1 --trace` | |||
There was a problem hiding this comment.
And this was passing? :)
There was a problem hiding this comment.
Yes.
db:test:prepare => db:test:load => db:test:load_structure
db:test:clone => db:test:clone_structure => db:test:load_structure
Both tasks called db:test:load_structure.
There was a problem hiding this comment.
Ah ok, got it, thanks.
|
I think they could be one commit yeah, but no worries. Thanks! |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jun 27, 2012
Fix wrong testcase for db:test:prepare, and wrong environment in AR rake task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, I had some mistakes.
I think they are individual commits, but if we should squash these, I'll update.