accepts_nested_attributes_for not working more than one level deep? #695

Closed
lighthouse-import opened this Issue May 16, 2011 · 7 comments

Comments

Projects
None yet
2 participants
@lighthouse-import

Imported from Lighthouse. Original ticket at: http://rails.lighthouseapp.com/projects/8994/tickets/5032
Created by scrozier - 2010-07-02 00:21:27 UTC

This is a bit preliminary, but since it is related to a recently resolved ticket (2415), I thought it worth reporting.

After installing 2-3-stable today, my one-level-deep nested attributes are now updating correctly, but I am still seeing a problem when there is more than one level of nesting. In that case, it is looking like the "grandchildren" records are only updated if at least one attribute changes in the related "child" record. Otherwise, no update is done on the grandchildren.

It's quite possible that this is my problem...anyone else?

Working on a test case....

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by scrozier - 2010-07-02 05:10:30 UTC

A little more info:

I can consistently reproduce this in my application.

I can "fix" this by making the changed? method in module Dirty return true if self.class == Child. Making the condition self.class == Grandchild does not work.

I am trying to backtrace this to a higher level call....

Imported from Lighthouse.
Comment by scrozier - 2010-07-02 05:10:30 UTC

A little more info:

I can consistently reproduce this in my application.

I can "fix" this by making the changed? method in module Dirty return true if self.class == Child. Making the condition self.class == Grandchild does not work.

I am trying to backtrace this to a higher level call....

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by scrozier - 2010-07-02 22:12:21 UTC

Forcing a change to Child also make grandchildren update correctly, as expected.

Imported from Lighthouse.
Comment by scrozier - 2010-07-02 22:12:21 UTC

Forcing a change to Child also make grandchildren update correctly, as expected.

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by Jeff Kreeftmeijer - 2010-11-08 08:27:19 UTC

Automatic cleanup of spam.

Imported from Lighthouse.
Comment by Jeff Kreeftmeijer - 2010-11-08 08:27:19 UTC

Automatic cleanup of spam.

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by Santiago Pastorino - 2011-02-09 00:31:58 UTC

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

Imported from Lighthouse.
Comment by Santiago Pastorino - 2011-02-09 00:31:58 UTC

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by Ingo Wichmann - 2011-03-18 14:53:34 UTC

Using rails 2.3.11 I can confirm this bug

Imported from Lighthouse.
Comment by Ingo Wichmann - 2011-03-18 14:53:34 UTC

Using rails 2.3.11 I can confirm this bug

@lighthouse-import

This comment has been minimized.

Show comment Hide comment
@lighthouse-import

lighthouse-import May 16, 2011

Imported from Lighthouse.
Comment by Daniel - 2011-03-18 18:51:39 UTC

[state:open]
I also still see this problem in 2.3.11.

Imported from Lighthouse.
Comment by Daniel - 2011-03-18 18:51:39 UTC

[state:open]
I also still see this problem in 2.3.11.

@josevalim josevalim closed this May 16, 2011

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim May 16, 2011

Contributor

Works fine on 3.0.x.

Contributor

josevalim commented May 16, 2011

Works fine on 3.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment