don't escape options in option_html_attributes method #7123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {:onclick => "alert("<code>")"}, | ||
| option_html_attributes([ 'foo', 'bar', { :onclick => %(alert("<code>")) } ]) | ||
| ) | ||
| end |
There was a problem hiding this comment.
How about changing this one to test options_for_select with special chars instead? :)
There was a problem hiding this comment.
I can but looks like there are a lot of tests that test this behavior implicity. E.g https://github.com/nashby/rails/blob/f5760d571445156c576925c4889fbd50ec388c6f/actionpack/test/template/form_options_helper_test.rb#L119
wdyt?
There was a problem hiding this comment.
I agree with @carlosantoniodasilva, adding one more case doesn't hurt.
There was a problem hiding this comment.
@rafaelfranca @carlosantoniodasilva OK, I've updated PR.
we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options
rafaelfranca
added a commit
that referenced
this pull request
Jul 22, 2012
don't escape options in option_html_attributes method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't need to escape values in this method as we pass
these html attributes to
tag_optionsmethod that handle escaping aswell.
it fixes the case when we want to pass html5 data options