Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activemodel tests runnable without -Itest and from non-root folders #7124

Closed
wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jul 21, 2012

I try to make testing as easy as possible, which means for me that every test file should be runnable with ruby pat/to/file_test.rb from everywhere, which is also a requirement for a few editors, this failed in activemodel.
(I'll make more pull requests for the other rails parts if this one is accepted)

@steveklabnik
Copy link
Member

This does not merge cleanly any more, and will need a rebase.

@grosser
Copy link
Contributor Author

grosser commented Sep 21, 2012

@steveklabnik do I get a merge if I do ?

@steveklabnik
Copy link
Member

I'm not allowed to merge code. :( I personally like it.

@grosser
Copy link
Contributor Author

grosser commented Sep 21, 2012

@josevalim would you merge it ?

@rafaelfranca
Copy link
Member

@grosser thank you for the pull request.

For me is not a problem writing -Itest and I don't see the point of changing this since it will make more difficult to add new test files because we have to take care with the relativity of the folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants