AR::Relation#order: make new order prepend old one. #7176
Conversation
|
An incredibly minor issue, but is it possible to change the example in the comments / commit message to not use the same column twice? On a first read, that made me think this was specifically related to calling |
|
Agree. Also you will need to rebase |
|
Fixed comment. Rebased code. |
| @@ -319,6 +319,11 @@ def find_first | |||
| end | |||
| end | |||
|
|
|||
| def default_scope_has_order? | |||
| default_scope = klass.send(:build_default_scope) | |||
There was a problem hiding this comment.
This send seems a smell. I think we should refactor to make this method public but part of our private API.
There was a problem hiding this comment.
also build_default_scope is not used in any place inside the framework. I don't know if it is there for historial reason.
There was a problem hiding this comment.
The last usage of this method was removed @ 8572ae6
|
Fixed |
|
"This pull request cannot be automatically merged." :D |
User.order("name asc").order("created_at desc")
# SELECT * FROM users ORDER BY created_at desc, name asc
This also affects order defined in `default_scope` or any kind of associations.
|
rebased |
AR::Relation#order: make new order prepend old one.
Original PR and discussion #2008.
This also affects order defined in
default_scopeor any kind of associations.cc @tenderlove