Indentation should consider line number character count. #7244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you take a screenshot of the before and after this commit? Also, is possible to add tests to this? |
|
I'm asking this because I didn't get the issue that you are fixing here. |
|
No prob. I'll make a new rails app to grab the screenshots and I'll upload asap. |
|
Hi. I have uploaded a screenshot of the before: http://i.imgur.com/ba82I.png Please let me know if you need anything else. |
|
Any updates on this @rafaelfranca ? Would you like me to add anything more? |
|
I'll take a look today. |
|
Please squash your commits, thanks. |
|
@carlosantoniodasilva @rafaelfranca Commits are squashed. Please let me know if you guys need anything else. |
|
@lucasuyezu looks good, thanks! |
carlosantoniodasilva
added a commit
that referenced
this pull request
Aug 15, 2012
Fix indentation on template errors to consider line number character count.
For instance, when an error is shown, if the related source code snippet has line numbers from, lets say, 8-12, the lines are left aligned, which means the code indent is wrong:
8: foo
9: bar
10: raise
11: baz
12: ...
This changes it to right align the source code snippet, so that the indentation is correct:
8: foo
9: bar
10: raise
11: baz
12: ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an error page that shows lines 8-12 for example, the source would not be aligned properly from line 10 onwards.
This commit fixes that.