Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actionpack/lib/action_view/log_subscriber.rb #7366

Closed
wants to merge 1 commit into from
Closed

Update actionpack/lib/action_view/log_subscriber.rb #7366

wants to merge 1 commit into from

Conversation

sailor
Copy link

@sailor sailor commented Aug 16, 2012

Decreased log level for rendered partials

@rafaelfranca
Copy link
Member

Why?

@sailor
Copy link
Author

sailor commented Aug 16, 2012

I can't find any option to get rid of those lines in my production log file, and i think it may be a better default. Or maybe, an option to disable the logging of rendered partials would be better

@rafaelfranca
Copy link
Member

Well, in master you can do config.action_view.logger = nil to disable Action View logger.

I don't think we should decrease the log severity because this information is not specific to developers. This is about the system operation.

INFO 
generic (useful) information about system operation

DEBUG 
low-level information for developers

@sailor
Copy link
Author

sailor commented Aug 16, 2012

I get an error with this config.

NoMethodError: undefined method `logger=' for ActionView::Base:Class

@rafaelfranca
Copy link
Member

This configuration is only present in master and will be available in Rails 4.0 only.

@rafaelfranca
Copy link
Member

I started a discussion with the Rails Core and we agree that these information are being shown in the right level (info). Unfortunately you can't disable it in 3.2 but we added this feature to 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants