i18n error messages: custom formats by attribute

[ey-pairing]

First place lookup is now: errors.formats.attributes.#{attribute}

Example use case:

errors:
  attributes:
    last_name:
      blank: you must provide your full name
  formats:
    attributes:
      last_name: "%{message}"

(same fallbacks as before)

[ey-pairing]

This patch could also be reasonably be applied to 3.2-stable branch

[rafaelfranca]

:default => [:"errors.format", "%{attribute} %{message}"],

[josevalim]

Thanks. This looks fine to me. Although we need to update the documentation (or properly document Errors#full_messages if it doesn't mention errors.formats yet).

[rafaelfranca]

Thank you.

Seems good. I made a code convention comment.

Also we will need a CHANGELOG entry and update the documentation for this.

Unfortunately we don't merge feature addition to 3-2-stable. This branch is only fo bug fixes now.

[jacobo]

Thanks for the prompt reply!

Should we submit a CHANGELOG change as part of this pull request?

By documentation do you mean just the bit of comments above def full_message or is there somewhere better?

[rafaelfranca]

Yes, CHANGELOG should be added as part of this pull request.

I would add the documentation in the comments above the full_message definition. Something like what is above the def generate_message in the same file.

[sidonath]

Shouldn't it really be looking for the string under :"#{@base.class.i18n_scope}.errors" (activerecord/activemodel) namespace first (just like it is done for validation error messages)?

Additionally, this doesn't allow us to set different message formats for fields with the same name in different models. Should it support that? Maybe this syntax would be additional fallback? Basically we could have defaults array that's similar to the one constructed in ActiveModel::Errors#generate_message.

Or maybe I should do another pull request to add these things :)

Thoughts?

[frodsan]

any news on this?

[bai]

Any updates on this one?

[steveklabnik]

@jacobo @ey-pairing it's been... 5 months since we've heard from you. If you're interested in keeping up with this pull request, please let me know, but I'm giving this a close as stale . Thanks.