Ensure valid migration filename on generating migration

[releu]

rails g migration add_statistic_updated_at:datetime

create    db/migrate/20120822103649_add_statistic_updated_at:datetime.rb

rake db:migrate

llegal name for migration file: ...db/migrate/20120822103649_add_statistic_updated_at:datetime.rb
    (only lower case letters, numbers, and '_' allowed)

[josevalim]

We should not reference ActiveRecord from the Rails directory. Or we should move this validation to the Active Record migration generator or provide a similar error in Rails. Given that this validation is specific to Active Record, I would do the former.

[releu]

Thanks.

I have moved validation to AR. Is it ok to use AR::IllegalMigrationNameError in tests?

[jeroeningen]

It is nice to raise an error if the name of the migration is incorrect.
But on the other side I think it's a little overkill...

[releu]

So.. Merge or Close?

[route]

I'm 👍, just squash your commits into one and rebase, otherwise it will be the next request ;)

[steveklabnik]

Yep, both those will need done.

[releu]

All done

[homakov]

👍 Also I just want rails putthingsback command that will revert just created crap

[steveklabnik]

Somehow, it's out of date again.

[releu]

I don't understand what is wrong. What should I do?

[steveklabnik]

Rebase it again. This happens often when CHANGELOGS get merged, they tend to cause a conflict.

[releu]

Rebased

[homakov]

@steveklabnik you don't see a green button right? Btw why github doesn't show other people that this PR needs to be rebased?

[releu]

Another one rebase :)

[steveklabnik]

Btw why github doesn't show other people that this PR needs to be rebased?

No idea. You should tell them. ;)

[releu]

Is it unavailable again?

[steveklabnik]

Oh, no, you're good. I'm not allowed to merge, or I would. You'll have to wait for someone on core.

[releu]

bump!