Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build about TemplateDigestorTest. #7485

Merged
merged 1 commit into from Aug 30, 2012

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Aug 30, 2012

I found the following test failure.

  1) Error:
143test_collection_dependency(TemplateDigestorTest):
144Errno::ENOENT: No such file or directory - /home/vagrant/builds/rails/rails/actionpack/test/template/../tmp/messages/_message.html.erb
145    /home/vagrant/builds/rails/rails/actionpack/test/template/digestor_test.rb:153:in `initialize'
...

This problem came from FiltUtils.cp_r(src, dest) specific.
According to API reference, if dest is directory, files were copied to dest/src directory.
We copy files in setup, and remove directory in teardown.
Thus if we execute tests twice, tests are failure at first, and tests are success at second.

rafaelfranca added a commit that referenced this pull request Aug 30, 2012
Fix build about TemplateDigestorTest.
@rafaelfranca rafaelfranca merged commit 404ddd2 into rails:master Aug 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants