Decode attributes pulled from URI.parse #7593
Conversation
|
A test case would be helpful - probably best to add it in test/cases/connection_specification/resolver_test.rb. |
|
Tests included. Also silenced some 1.9.x deprecation warning for URI.unescape |
|
Could you squash your commits? Thanks. |
|
@frodsan done. looks like i botched my commit message in the squash. :/ |
| @@ -73,6 +73,8 @@ def connection_url_to_hash(url) # :nodoc: | |||
| :database => config.path.sub(%r{^/},""), | |||
| :host => config.host } | |||
| spec.reject!{ |_,value| value.blank? } | |||
| uri_parser = URI.const_defined?(:Parser) ? URI::Parser.new : URI | |||
There was a problem hiding this comment.
When the Parser is not available?
There was a problem hiding this comment.
Was trying to make this safe for 1.8. Not sure it's needed at this point. Thoughts?
There was a problem hiding this comment.
You don't have to worry about 1.8. Master branch version only supports >= 1.9.3.
|
Could you add a CHANGELOG entry? |
|
@rafaelfranca sure, do you want me to incorporate the changes above as well? |
|
@rafaelfranca Done. Squashed with previous and incorporated comments from above review. Thanks! |
| @@ -36,9 +36,13 @@ | |||
| implementation is very small and it's probably not worth putting users | |||
| through lots of annoying deprecation warnings. | |||
|
|
|||
| *Shawn Veader* | |||
There was a problem hiding this comment.
This CHANGELOG entry is wrong. It should be at top of the file and the author name is below the change.
The RFC indicates that username and passwords may be encoded. http://tools.ietf.org/html/rfc2396#section-3.2.2 Found this trying to use the mysql://username:password@host:port/db and having special characters in the password which needed to be URI encoded.
|
@rafaelfranca Apologies... fixed. (Someone needs sleep and/or more coffee.) |
|
Thank you so much for the pull request. |
Decode attributes pulled from URI.parse
|
👍 Thanks. |
Decode attributes pulled from URI.parse Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/connection_adapters/connection_specification.rb
The RFC indicates that username and passwords may be encoded.
http://tools.ietf.org/html/rfc2396#section-3.2.2
Found this trying to use the mysql://username:password@host:port/db and having special characters in the password which needed to be URI encoded.