Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change query pattern case insensitive #7782

Merged

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Sep 28, 2012

This pull request address the failure below.
This failure happens because Oracle adapter uses upper case attribute/column name.

$ ARCONN=oracle ruby -Itest test/cases/dirty_test.rb
Using oracle
Run options: --seed 63746

Running tests:
F................................

Finished tests in 1.533941s, 21.5132 tests/s, 116.0410 assertions/s.

1) Failure:
test_0001_partial insert(DirtyTest) [test/cases/dirty_test.rb:557]:
Query pattern(s) /first_name/ not found.
Queries:
INSERT INTO "PEOPLE" ("CREATED_AT", "FIRST_NAME", "ID", "UPDATED_AT") VALUES (:a1, :a2, :a3, :a4)

33 tests, 178 assertions, 1 failures, 0 errors, 0 skips
$

This fix has been tested with sqlite3, mysql, mysql2 and postgresql adapters also.

because Oracle adapter uses upper case attribute/column name.
rafaelfranca added a commit that referenced this pull request Sep 28, 2012
…al_inserts

Change query pattern case insensitive
@rafaelfranca rafaelfranca merged commit a7f8872 into rails:master Sep 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants