Update redcarpet dependency #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this being bumped? What's in 2.2.2 that we need that wasn't in 2.2.1? |
|
It was at 2.1.1, not 2.2.1. The dependency is out of date. |
|
Ahhhhh. Yeah. Sorry. |
| @@ -18,7 +18,7 @@ gem 'activerecord-deprecated_finders', github: 'rails/activerecord-deprecated_fi | |||
|
|
|||
| # This needs to be with require false to avoid | |||
| # it being automatically loaded by sprockets | |||
| gem 'uglifier', require: false | |||
| gem 'uglifier', :require => false | |||
There was a problem hiding this comment.
This change is unnecessary.
There was a problem hiding this comment.
Ah, yeah, I read the diff wrong. We absolutely want the 1.9 syntax
"~> 2.2.2" from "~> 2.1.1". Also converted all hash rockets in the Gemfile to the 1.9 syntax.
|
I've set the previously modified hash back to the 1.9 syntax, and converted an additional. All hashes in the Gemfile are now 1.9 style, and the previous version number change obviously still stands. |
| @@ -4,7 +4,7 @@ gemspec | |||
|
|
|||
| gem 'arel', github: 'rails/arel', branch: 'master' | |||
|
|
|||
| gem 'mocha', '>= 0.11.2', :require => false | |||
| gem 'mocha', '>= 0.11.2', require: false | |||
carlosantoniodasilva
added a commit
that referenced
this pull request
Oct 26, 2012
Update redcarpet dependency
|
@gbchaosmaster thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"
> 2.2.2" from "> 2.1.1". Also removed a hash rocket in the Gemfile onthat same line, and created another that was necessary because the 1.9
syntax messed up syntax highlighters.