Allow Relation.where with no arguments to be chained with new query methods not, like, and not_like
#8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples: Model.where.not field: nil #=> "SELECT * FROM models WHERE field IS NOT NULL Model.where.like name: 'Jeremy%' #=> "SELECT * FROM models WHERE name LIKE 'Jeremy%' this feature was originally suggested by Jeremy Kemper rails#5950 (comment) Closes rails#5950
This feature was originally suggested by José Valim rails#8332 (comment) The original commit fddf9c2 by Akira Matsuda enabled the methods #not, #like, and #not_like to be chained to a Relation.where with no args. This commit maintains the same behavior, but requires using #where before chaining any of the previous methods, which makes chaining clearer. Closes rails#5950
|
Thank you for implementing, @claudiob. However, let's give the original author the honors ❤️ Please do open a PR with improvements after his work is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #8332 this commit closes #5950 by making available three new methods
not,like, andnot_likethat can be chained with a Relation.where with no (or nil) arguments.The difference is that this commit follows the suggestion by José Valim #8332 (comment) to use a class and a builder, rather than a mixin, to implement WhereChain.