do not append a second slash when using trailing_slash: true
#8701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acapilleri I kind of prefer the current version. I know it has a little duplication but I like how it reads. |
| Class.new do | ||
| def url_options | ||
| options = super | ||
| define_method :url_options do |
There was a problem hiding this comment.
Why do we need to change it do define_method?
There was a problem hiding this comment.
Otherwise I can't pass additional_options through.
rafaelfranca
added a commit
that referenced
this pull request
Jan 2, 2013
…lash do not append a second slash when using `trailing_slash: true`
senny
added a commit
to senny/rails
that referenced
this pull request
Jan 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source issue is #8700
I changed the code to only append a "/" when the current path does not already end with "/". I added the test-case to routing_test instead of url_for_test to make sure, the right arguments are passed to
url_forand end up in the right url.