Cleaning up ActiveModel::Dirty tests #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adomokos
commented
Jan 14, 2013
adomokos
commented
- Clarifying what the #changed method returns
- Adding tests to describe what the #changed_attributes returns
|
👍 on the added test, but 👎 on the test naming convention. I don't think Rails does have a convention of 'prefix the test with method name'. |
|
@sikachu: What do you think now? |
|
|
||
| @model.name = "John" | ||
| assert_equal({ "name" => "Paul" }, @model.changed_attributes) | ||
| end |
There was a problem hiding this comment.
Seems fine, I think you can move it to here. Thanks.
* Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment
|
@carlosantoniodasilva: I moved it. Let me know if this works. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jan 15, 2013
…butes Cleaning up ActiveModel::Dirty tests
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.