schema dumper tests now conducted by ActiveRecord::Base.Connection

[ranjaykrishna]

We abstracted the test for valid data types from databases from the schema dumper to Connection. We set it so that sqlite would approve all values. However, you can not create arbitrary types in sqlite as it still checks against its native_database_types.

[jaggederest]

Updated patch looks good, but I don't think it requires releasing the Kraken just yet :) commit da19327 introduced a change that isn't otherwise used here.

[jaggederest]

👍

[jeremy]

👾

[carlosantoniodasilva]

Please make sure you squash the commits :).

[ranjaykrishna]

How do I squash the commits?

[carlosantoniodasilva]

I think this post from @steveklabnik might help :)

[ranjaykrishna]

@carlosantoniodasilva I think I have squashed the commits.

[steveklabnik]

It still says there are 11: https://github.com/rails/rails/pull/9204/commits

Did you force push to the branch successfully?

[ranjaykrishna]

I believe that the commits have now been successfully squashed here as well.

[rubys]

This change impacts the ability to create a db/schema.rb file. See:

f8c8ad5#L3R608

[kenips]

Yes, seeing same error here.

[rubys]

I didn't draw the connection at the time, but I'm seeing lots of errors as a result of this:

http://intertwingly.net/projects/AWDwR4/checkdepot/

All go away if valid_type? is made public.

[ranjaykrishna]

I just moved them to public methods. Running additional tests now.

[jonleighton]

Hi @ranjaykrishna, I have reverted this commit because it introduced caused a failing test. I have also reverted the commit by @rubys as it relates solely to this commit. Please fix up the test and send a new PR incorporating the commit by @rubys also.