Find() on an association with an inverse will now scan existing in-memory records #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the association already holds that record in memory before checking the database for the specified ids.
jeremy
added a commit
that referenced
this pull request
Mar 19, 2013
Find() on an association with an inverse will now scan existing in-memory records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in #9470 is that when a user defines
:inverse_ofin an association, thefind()method does not check the records that are already loaded in the association, but will instead go to the database directly.I've changed this so that when a user calls
find()on an association which has an:inverse_offlag, then thefind_by_scan()method is called, which basically does a scan over the loaded_target (which includes all current children, including new and existing records).