Routing match via option requirement exception message made more explicit
#9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,7 +181,8 @@ def normalize_conditions! | |||
|
|
|||
| if !via_all && options[:via].blank? | |||
| msg = "You should not use the `match` method in your router without specifying an HTTP method.\n" \ | |||
| "If you want to expose your action to GET, use `get` in the router:\n\n" \ | |||
| "If you want to expose your action to both GET and POST, use `via: [:get, :post]` option.\n" \ | |||
There was a problem hiding this comment.
Perhaps "add via: [:get, :post] option." instead of "use" in this line would make more sense? Otherwise it makes sense adding this note.
|
@carlosantoniodasilva force-pushing removed the commit you commented at 💥. But I did what you suggested. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Mar 5, 2013
…ment_exception_message Routing match `via` option requirement exception message made more explicit
|
Thanks. |
It's supposed to, but github gives you an 'outdated diff discussion' link, so you can still read it. :) |
inossidabile
deleted the
explicit_match_via_requirement_exception_message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current exception message makes it feel like
matchwas removed completely. I believe it should be more explicit aboutviaoption (at least since it is a root reason of the exception itself). Clarified it a bit.