Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary lines from test case #9612

Closed
wants to merge 1 commit into from

Conversation

choudhuryanupam
Copy link

Removed the unnecessary lines.

@rafaelfranca
Copy link
Member

I'm not sure these lines are unnecessary so I think is better to leave it as it is

@choudhuryanupam
Copy link
Author

The removed lines are tailored into an one-liner, so no harm done. The re-written one line will serve the purpose of the removed lines, so no worries.

@rafaelfranca
Copy link
Member

I don't think so, the test description is explicitly saying that the test is for when you the set foreign key after the object load and the one line is not doing this.

@choudhuryanupam
Copy link
Author

Right...the removed lines kill the purpose of the test case.

@rafaelfranca
Copy link
Member

Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants