Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is RDoc 4.x supported in Rails 3.2? #9634

Closed
voxik opened this issue Mar 9, 2013 · 21 comments
Closed

Is RDoc 4.x supported in Rails 3.2? #9634

voxik opened this issue Mar 9, 2013 · 21 comments

Comments

@voxik
Copy link
Contributor

voxik commented Mar 9, 2013

Is there any reason, why RDoc 4.x should not be used? Can the dependency in Railties be relaxed? Thank you.

@fxn
Copy link
Member

fxn commented Mar 9, 2013

Rails 3 only gets bug and security fixes, RDoc 3 is fine for Rails 3 thanks.

@fxn fxn closed this as completed Mar 9, 2013
@voxik
Copy link
Contributor Author

voxik commented Mar 9, 2013

That is sad :/ You give me no other chance then patch this dependency in Fedora. This doesn't help Fedora, nor Rails nor anybody else :(

@fxn
Copy link
Member

fxn commented Mar 9, 2013

A tiny release 3.2.x is not going to gratuitously upgrade RDoc in the machines of all users.

@voxik
Copy link
Contributor Author

voxik commented Mar 9, 2013

I am not asking you to force RDoc 4.x, I am asking you to relax the dependency, if possible, i.e. instead of ~> 3.4 use >= 3.4. Ruby 2.0 comes with RDoc 4.x, why do you want to force everybody to install older RDoc? On Fedora, we even cannot install older version using YUM/RPM and I believe that Fedora is not exception in this.

@voxik
Copy link
Contributor Author

voxik commented Mar 9, 2013

This is the patch I am going to use in Fedora 19, which goes with Ruby 2.0.0:

http://pkgs.fedoraproject.org/cgit/rubygem-railties.git/tree/rubygem-railties-3.2.12-relax-rdoc-dependency.patch

@voxik
Copy link
Contributor Author

voxik commented Mar 11, 2013

BTW if you consider support of Ruby 2.0 and you are doing bugfixes due to it, I see no difference to support RDoc 4.x

@fxn
Copy link
Member

fxn commented Mar 11, 2013

Yeah, if we need to relax the constraint due to support for Ruby 2.0 then we would do it.

@voxik
Copy link
Contributor Author

voxik commented Mar 11, 2013

But why are you going to support Ruby 2.0 without supporting RDoc 4.x? If you can support Ruby 2.0, you can support RDoc 4.x, can't you? What can I do to convince you? Would PR make some difference?

@fxn
Copy link
Member

fxn commented Mar 11, 2013

By now not even Rails 4 is going to depend on RDoc 4, we depend on RDoc 3 via SDoc as of this writing.

@voxik
Copy link
Contributor Author

voxik commented Mar 11, 2013

It is interesting. You made me search for 'rdoc' in Rails and I really can't see any place why it should be runtime dependecy of railties. There is no single file what so ever which could be essential to run Rails but you still enforce the dependency and you are even picky about its version.

@voxik
Copy link
Contributor Author

voxik commented Mar 19, 2013

Interestingly enough, mail dependency can be bumped in 3.2.13. I see not other reason to update then that new mail version is available a497f84. Moreover, mail 2.4.x is apparently still maintained. Please update the RDoc. Thank you.

@fxn
Copy link
Member

fxn commented Mar 19, 2013

As already said, we'll do it if the project needs it.

In Ruby different gem versions coexist just fine thanks to RubyGems, and each lib requires whatever. If you are dealing with a more restrictive environment than Ruby itself, then go patch whatever you need to patch.

@voxik
Copy link
Contributor Author

voxik commented Mar 19, 2013

So I am not part of the project? Neither Fedora, Red Hat, CentOS users are part of the project? Interesting. Thank you.

@fxn
Copy link
Member

fxn commented Mar 19, 2013

You are part of the project, and I'd like to do my best to make your life easy. But SDoc as of this writing does not support RDoc 4.

@zzak
Copy link
Member

zzak commented Mar 23, 2013

There is some work going on to support RDoc 4 in SDoc (see: rails/sdoc#43).

@fxn could an sdoc release with rdoc 4 support make it into rails 4?

@fxn
Copy link
Member

fxn commented Mar 23, 2013

@zzak that would be great.

@translunar
Copy link

Hi folks, we're running into a problem with railties' RDoc version requirement.

NMatrix issue 149: SciRuby/nmatrix#149

NMatrix needs RDoc >= 4.0.1, because NMatrix is a mixture of C and C++, and earlier RDoc versions choke on the C++ version of its init_nmatrix entry point.

Any thoughts on how we can make the two gems work together? Let me know if I should open a new issue.

Cheers,
John Woods
SciRuby Project

@zzak
Copy link
Member

zzak commented Jan 23, 2014

@MohawkJohn @voxik Just a heads up, this will be fixed with the release of Rails 4.1!

@fxn
Copy link
Member

fxn commented Jan 23, 2014

Hi there! Let me also add that in Rails 4.0 the gem dependency was removed and SDoc became a dependency in the generated Gemfile for new apps.

@voxik
Copy link
Contributor Author

voxik commented Jan 24, 2014

@zzak @fxn Thank you. That is good news!

@translunar
Copy link

Wonderful, @zzak! Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants