Add support of String#to_boolean

[cfabianski]

No description provided.

[cfabianski]

I don't think it's a good idea to use a regexp for that purpose as it's time-consuming and it should be processed twice (true and false).
include? better fits this needs IMO

[steveklabnik]

Can you demonstrate a real-world use case of this making code cleaner? We don't add extensions to String unless it's really important.

[vijaydev]

👎

[cfabianski]

if string.to_boolean instead of if string == "true" || string == "t" || string == "1"
For instance, when you have to check the value of _destroy in accepts_nested_attributes

[josevalim]

That's an issue of accept nested attributes for. Maybe it should yield this
parameter by default?

In any case, -1 for this PR, even more because its implementation is very
couple to what Active Record consider to be Boolean conversions.

José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Lead Developer

[ptn]

It would seem to be overkill to extend a Ruby core class to make the code in this one very particular use case a little terser. How about a helper function in ApplicationController?

[rafaelfranca]

I agree with @josevalim. Closing.

Thank you for the pull request.

[cfabianski]

Thanks for reviewing and your fast feedbacks :-)
I won't touch core_ext anymore :-)

[johnnyshields]

This is a nice utility function to have when importing other people's data. Was expecting ActiveSupport would have something like it.