Rails 4 upgrade notes about clashing named route selection changes

[trevorturk]

Document change to clashing named route selection. Rails 4 correctly prefers the first named route. (Likely from rails/journey@98a9802)

[steveklabnik]

/cc @fxn

[carlosantoniodasilva]

👍

[trevorturk]

I'd like to log a warning when a route is skipped here:

https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/journey/routes.rb#L61

I'm not sure how best to do that, though -- @steveklabnik or @carlosantoniodasilva have any ideas?

[carlosantoniodasilva]

@trevorturk this is what comes up to my mind right now:

if name
  if named_routes[name]
    ActiveSupport::Deprecation.warn("BOOM")
  else
    named_routes[name] = route
  end
end

It could be moved to a private method like add_named_route or something like that if necessary, to be called in that place, wdyt?

[trevorturk]

Yeah, I was thinking using ActiveSupport::Deprecation would be frowned upon, but it'd work!

Want to work something up, or shall I?

[carlosantoniodasilva]

Hm right, I guess we should not use AS::Deprecation, it's probably better to use ActionController::Base.logger.warn right?

[trevorturk]

@carlosantoniodasilva took a stab at it in #9704 -- worked nicely in my local testing. If we go ahead with that, I'd like to update this PR to mention the logging -- much easier than trying to read through the rake routes output.

[schneems]

👍 on this, any other concerns we need to address before merging in this doc addition?

[trevorturk]

IMO it's good to go -- I made a separate PR #9704 where we can discuss logging or any other helpful stuff we might consider doing. If we go ahead with that, I'll update this section as well.

[rafaelfranca]

Thank you

[carlosantoniodasilva]

❤️