Unserializing YAML attributes can silently fail in development mode #9975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The above patch will at least re-raise the argument error. I'm not convinced we should ever swallow these exceptions though. When would we want to get a string of bad YAML back instead of being told our object is invalid? That seems surprising. If we want to keep swallowing some errors, it might be nice to create another custom error class that gives the missing class name and suggests that the user require_dependency it. I'm happy to do that if there is interest. |
|
Is this really an ArgumentError? Seems more like TypeError or similar |
|
The error comes from YAML, so I can't control that. We could wrap it, I'm just not sure if it makes sense. |
|
@tenderlove This has been updated as we discussed. |
tenderlove
added a commit
that referenced
this pull request
Apr 2, 2013
…unserialized Unserializing YAML attributes can silently fail in development mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a serialized attribute on an ActiveRecord model and the object to be unserialized has not yet been loaded, AR will silently return the YAML string. This can be confusing to new users and apparently to me, even though I've been bitten by this three or four times in the past.