-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(erb) .rb generator files should be renamed to .rb.erb #23847
Comments
I don't see any problem of using the On Wed, Feb 24, 2016, 09:01 Chashmeet Singh notifications@github.com
|
@chashmeetsingh thanks, but I thought that a file that doesn't load by Ruby "should not" be named @rafaelfranca assume you have a Rails app and you'd like to pre-compile your e.g.
have mostly used |
I see. I'm fine with renaming them. |
OK thanks, will setup a PR - this affects several gems. is it acceptable if I use the |
|
OK |
This issue has been automatically marked as stale because it has not been commented on for at least The resources of the Rails team are limited, and so we are asking for your help. If you can still reproduce this error on the Thank you for all your contributions. |
This issue has been automatically closed because of inactivity. If you can still reproduce this error on the Thank you for all your contributions. |
assuming they do not contain valid ruby code they should not be named .rb
this would not only be cleaner but allow tools such as Warbler pre-compiling .rb files without hustle
each sub-gem seems to have these under lib/rails/generators e.g. with active_record :
https://github.com/rails/rails/tree/master/activerecord/lib/rails/generators/active_record/model/templates
lib/rails/generators/active_record/model/templates/model.rb -> .../model.rb.erb
lib/rails/generators/active_record/model/templates/module.rb -> .../module.rb.erb
proposing to rename those and update the related files, would this be acceptable by the team?
The text was updated successfully, but these errors were encountered: