-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AR causes stack level too deep when joining tables #25653
Comments
Related to #18109 |
It looks like the regression was introduced by 12e9e38. |
cc @sgrif |
@k0kubun Can you take a look at this? |
I guess this can be resolved in the same way as #25187 and only that direction can solve both problems. But as you can see from the discussion in the PR, By the way, just curious, why do you do circular joins and refer to |
@k0kubun don't ask why. :D I found this use case in some gem. |
Ah, I see. It may be difficult to fix since it's caused in a gem. Sorry for the trouble and thank you for reporting it. |
Sent a patch to fix this issue. #25702 |
@k0kubun branch solves the problem. |
Steps to reproduce
Expected behavior
Should work same as in AR4.2.6 (I hope).
Actual behavior
Raises
System configuration
Rails version: 5.0.0
Ruby version: 2.2.4
The text was updated successfully, but these errors were encountered: