Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments from structure.sql for PostgreSQL adapter #28153

Closed
aripollak opened this issue Feb 24, 2017 · 1 comment
Closed

Remove comments from structure.sql for PostgreSQL adapter #28153

aripollak opened this issue Feb 24, 2017 · 1 comment
Labels
activerecord attached PR PostgreSQL

Comments

@aripollak
Copy link
Contributor

aripollak commented Feb 24, 2017 •
edited

When using the postgresql database adapter, run rake db:structure:dump. Note that the full version number is included in db/structure.sql:

-- Dumped from database version 9.5.4
-- Dumped by pg_dump version 9.5.4

If we check it into git, that means that anyone with a different minor version of PostgreSQL server would have differences in the file after running rake db:migrate. Would you accept a pull request to remove all "--" comments from the resulting structure.sql?
@rafaelfranca
Copy link
Member

Yes

@aripollak aripollak mentioned this issue Feb 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
activerecord attached PR PostgreSQL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rafaelfranca @aripollak @maclover7