Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Text and Action View unit tests are failing with ruby 2.8.0dev #38613

Closed
yahonda opened this issue Mar 1, 2020 · 6 comments
Closed

Action Text and Action View unit tests are failing with ruby 2.8.0dev #38613

yahonda opened this issue Mar 1, 2020 · 6 comments

Comments

@yahonda
Copy link
Member

yahonda commented Mar 1, 2020

Related to #38546

Action Text and Action View unit tests are failing since ruby/ruby@b9007b6 at ruby/ruby#2888 Here are minimum steps to reproduce at Action Text

Steps to reproduce

cd actiontext
bin/test "test/template/form_helper_test.rb"  "test/unit/model_test.rb"  -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/"

Expected behavior

It should pass.

Actual behavior

% bin/test "test/template/form_helper_test.rb"  "test/unit/model_test.rb"  -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/"
/Users/yahonda/.rbenv/versions/2.8.0-dev-yahonda/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2
/Users/yahonda/.rbenv/versions/2.8.0-dev-yahonda/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2
Run options: -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/" --seed 51853

# Running:

E

Error:
ActionText::ModelTest#test_embed_extraction:
NoMethodError: undefined method `runnables' for ActiveJob::Base:Class



bin/test /Users/yahonda/src/github.com/rails/rails/actiontext/test/unit/model_test.rb:32

E

Error:
ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments:
NoMethodError: undefined method `runnables' for ActiveStorage::BaseJob:Class



bin/test /Users/yahonda/src/github.com/rails/rails/actiontext/test/unit/model_test.rb:38



Finished in 0.211917s, 9.4377 runs/s, 0.0000 assertions/s.
2 runs, 0 assertions, 0 failures, 2 errors, 0 skips
%

System configuration

Rails version: master branch

Ruby version:ruby 2.8.0dev (2020-02-22T00:58:59Z master b9007b6c54) [x86_64-darwin19]

@yahonda
Copy link
Member Author

yahonda commented Mar 3, 2020

Opened this issue to https://bugs.ruby-lang.org/issues/16669

@yahonda
Copy link
Member Author

yahonda commented Mar 5, 2020

I'm working on creating some "smaller" test cases under Action View and having some hard time to create it. The problem is adding options provided by minitest_bisect does not reproduce the error.

Here are details:

  • Steps likely reproduce errors:
cd actionview
bin/test test/template/log_subscriber_test.rb test/template/template_test.rb test/template/test_case_test.rb test/template/atom_feed_helper_test.rb
  • Perform bin/test test/template/log_subscriber_test.rb test/template/template_test.rb test/template/test_case_test.rb test/template/atom_feed_helper_test.rb and find --seed 34960 reproduces errors
% cd actionview
% bin/test test/template/log_subscriber_test.rb test/template/template_test.rb test/template/test_case_test.rb test/template/atom_feed_helper_test.rb
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2
Run options: --seed 34960

# Running:

.................................................................E

Error:
AtomFeedTest#test_feed_xml_processing_instructions_duplicate_targets:
ArgumentError: wrong number of arguments (given 3, expected 1)
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/url_for.rb:108:in `initialize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `new'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `view_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:111:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/streaming.rb:218:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:103:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/rendering.rb:25:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:36:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
    /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/2.8.0/benchmark.rb:308:in `realtime'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/benchmark.rb:14:in `ms'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:86:in `cleanup_view_runtime'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:45:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:222:in `index'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:195:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:30:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:39:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:517:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:395:in `get'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:330:in `block in test_feed_xml_processing_instructions_duplicate_targets'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:372:in `block in with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:368:in `with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:329:in `test_feed_xml_processing_instructions_duplicate_targets'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:96:in `block (3 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:95:in `block (2 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `fork'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `block in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `times'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `each'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `map'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `start'


bin/test test/template/atom_feed_helper_test.rb:328

E

Error:
AtomFeedTest#test_feed_entry_type_option_default_to_text_html:
ArgumentError: wrong number of arguments (given 3, expected 1)
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/url_for.rb:108:in `initialize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `new'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `view_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:111:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/streaming.rb:218:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:103:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/rendering.rb:25:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:36:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
    /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/2.8.0/benchmark.rb:308:in `realtime'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/benchmark.rb:14:in `ms'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:86:in `cleanup_view_runtime'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:45:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:222:in `index'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:195:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:30:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:39:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:517:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:395:in `get'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:347:in `block in test_feed_entry_type_option_default_to_text_html'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:372:in `block in with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:368:in `with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:346:in `test_feed_entry_type_option_default_to_text_html'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:96:in `block (3 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:95:in `block (2 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `fork'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `block in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `times'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `each'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `map'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `start'


bin/test test/template/atom_feed_helper_test.rb:345

..E

Error:
AtomFeedTest#test_feed_xhtml:
ArgumentError: wrong number of arguments (given 3, expected 1)
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/url_for.rb:108:in `initialize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `new'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `view_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:111:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/streaming.rb:218:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:103:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/rendering.rb:25:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:36:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
    /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/2.8.0/benchmark.rb:308:in `realtime'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/benchmark.rb:14:in `ms'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:86:in `cleanup_view_runtime'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:45:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:222:in `index'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:195:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:30:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:39:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:517:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:395:in `get'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:338:in `block in test_feed_xhtml'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:372:in `block in with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:368:in `with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:337:in `test_feed_xhtml'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:96:in `block (3 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:95:in `block (2 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `fork'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `block in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `times'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `each'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `map'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `start'


bin/test test/template/atom_feed_helper_test.rb:336

....E

Error:
AtomFeedTest#test_feed_id_should_be_a_valid_tag:
ArgumentError: wrong number of arguments (given 3, expected 1)
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/url_for.rb:108:in `initialize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `new'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `view_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:111:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/streaming.rb:218:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:103:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/rendering.rb:25:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:36:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
    /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/2.8.0/benchmark.rb:308:in `realtime'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/benchmark.rb:14:in `ms'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:86:in `cleanup_view_runtime'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:45:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:222:in `index'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:195:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:30:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:39:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:517:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:395:in `get'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:282:in `block in test_feed_id_should_be_a_valid_tag'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:372:in `block in with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:368:in `with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:281:in `test_feed_id_should_be_a_valid_tag'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:96:in `block (3 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:95:in `block (2 levels) in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `fork'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:77:in `block in start'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `times'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `each'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `map'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/parallelization.rb:74:in `start'


bin/test test/template/atom_feed_helper_test.rb:280

............

Finished in 0.249986s, 348.0195 runs/s, 1068.0598 assertions/s.
87 runs, 267 assertions, 0 failures, 4 errors, 0 skips
%
  • Execute minitest_bisect with --seed 34960 to find culprit methods and find Final reproduction:
% bundle exec minitest_bisect test/template/log_subscriber_test.rb test/template/template_test.rb test/template/test_case_test.rb test/template/atom_feed_helper_test.rb --seed 34960
reproducing... in 1.72 sec
verifying... in 1.64 sec
# of culprit methods: 32 in 1.66 sec
# of culprit methods: 32 in 1.67 sec
# of culprit methods: 16 in 1.66 sec
# of culprit methods: 8 in 1.65 sec
# of culprit methods: 8 in 1.66 sec
# of culprit methods: 4 in 1.64 sec
# of culprit methods: 4 in 1.64 sec
# of culprit methods: 2 in 1.63 sec
# of culprit methods: 2 in 1.63 sec
# of culprit methods: 1 in 1.65 sec
# of culprit methods: 1 in 1.64 sec

Minimal methods found in 11 steps:

Culprit methods: ["AVLogSubscriberTest#test_render_inline_template"]

/Users/yahonda/.rbenv/versions/2.8.0-dev/bin/ruby -Itest:lib -e 'require "./test/template/log_subscriber_test.rb" ; require "./test/template/template_test.rb" ; require "./test/template/test_case_test.rb" ; require "./test/template/atom_feed_helper_test.rb"' -- --seed 34960  -n "/^(?:AVLogSubscriberTest#(?:test_render_inline_template)|ActionView::ClassMethodsTest#(?:test_additional_helper_classes_can_be_specified_as_in_a_controller)|ActionView::ControllerHelperMethod#(?:test_can_call_a_helper_method_defined_on_the_current_controller_from_a_helper)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance)|AtomFeedTest#(?:test_entry_should_only_use_published_if_created_at_is_present|test_entry_with_prefilled_options_should_use_those_instead_of_querying_the_record|test_feed_entry_type_option_default_to_text_html|test_feed_entry_type_option_specified|test_feed_entry_url_false_option_adds_no_link|test_feed_id_should_be_a_valid_tag|test_feed_should_include_atomPub_namespace|test_feed_should_include_two_entries|test_feed_should_use_default_language_if_none_is_given|test_feed_xhtml|test_feed_xml_processing_instructions|test_feed_xml_processing_instructions_duplicate_targets|test_providing_builder_to_atom_feed|test_self_url_should_default_to_current_request_url))$/"

Final reproduction:

/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2
Run options: --seed 34960 -n "/^(?:AVLogSubscriberTest#(?:test_render_inline_template)|ActionView::ClassMethodsTest#(?:test_additional_helper_classes_can_be_specified_as_in_a_controller)|ActionView::ControllerHelperMethod#(?:test_can_call_a_helper_method_defined_on_the_current_controller_from_a_helper)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance)|AtomFeedTest#(?:test_entry_should_only_use_published_if_created_at_is_present|test_entry_with_prefilled_options_should_use_those_instead_of_querying_the_record|test_feed_entry_type_option_default_to_text_html|test_feed_entry_type_option_specified|test_feed_entry_url_false_option_adds_no_link|test_feed_id_should_be_a_valid_tag|test_feed_should_include_atomPub_namespace|test_feed_should_include_two_entries|test_feed_should_use_default_language_if_none_is_given|test_feed_xhtml|test_feed_xml_processing_instructions|test_feed_xml_processing_instructions_duplicate_targets|test_providing_builder_to_atom_feed|test_self_url_should_default_to_current_request_url))$/"

# Running:

..........E

Error:
AtomFeedTest#test_feed_entry_type_option_default_to_text_html:
ActionView::Template::Error: undefined method `root' for Rails:Module
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:194:in `short_identifier'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:375:in `identifier_method_name'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:368:in `method_name'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:318:in `compile'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template/inline.rb:17:in `compile'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:282:in `block (2 levels) in compile!'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:205:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:379:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:281:in `block in compile!'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:273:in `synchronize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:273:in `compile!'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:182:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:205:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:383:in `instrument_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:181:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/template_renderer.rb:56:in `block (2 levels) in render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/abstract_renderer.rb:87:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/abstract_renderer.rb:86:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/template_renderer.rb:55:in `block in render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/template_renderer.rb:63:in `render_with_layout'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/template_renderer.rb:54:in `render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/template_renderer.rb:11:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:64:in `render_template_to_object'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:32:in `render_to_object'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:117:in `block in _render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/base.rb:303:in `in_rendering_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:116:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/streaming.rb:218:in `_render_template'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:103:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/renderers.rb:142:in `render_to_body'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/rendering.rb:25:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:36:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
    /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/2.8.0/benchmark.rb:308:in `realtime'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/benchmark.rb:14:in `ms'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:46:in `block in render'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:86:in `cleanup_view_runtime'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:45:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:222:in `index'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:195:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rendering.rb:30:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:39:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:517:in `process'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_controller/test_case.rb:395:in `get'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:347:in `block in test_feed_entry_type_option_default_to_text_html'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:372:in `block in with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:368:in `with_restful_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:346:in `test_feed_entry_type_option_default_to_text_html'


rails test Users/yahonda/src/github.com/rails/rails/actionview/test/template/atom_feed_helper_test.rb:345

.......

Finished in 0.122661s, 146.7459 runs/s, 342.4071 assertions/s.
18 runs, 42 assertions, 0 failures, 1 errors, 0 skips
%
  • Executed the first command with Final reproduction: option then somehow these errors do not reproduce
% bin/test test/template/log_subscriber_test.rb test/template/template_test.rb test/template/test_case_test.rb test/template/atom_feed_helper_test.rb --seed 34960 -n "/^(?:AVLogSubscriberTest#(?:test_render_inline_template)|ActionView::ClassMethodsTest#(?:test_additional_helper_classes_can_be_specified_as_in_a_controller)|ActionView::ControllerHelperMethod#(?:test_can_call_a_helper_method_defined_on_the_current_controller_from_a_helper)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance)|AtomFeedTest#(?:test_entry_should_only_use_published_if_created_at_is_present|test_entry_with_prefilled_options_should_use_those_instead_of_querying_the_record|test_feed_entry_type_option_default_to_text_html|test_feed_entry_type_option_specified|test_feed_entry_url_false_option_adds_no_link|test_feed_id_should_be_a_valid_tag|test_feed_should_include_atomPub_namespace|test_feed_should_include_two_entries|test_feed_should_use_default_language_if_none_is_given|test_feed_xhtml|test_feed_xml_processing_instructions|test_feed_xml_processing_instructions_duplicate_targets|test_providing_builder_to_atom_feed|test_self_url_should_default_to_current_request_url))$/"

/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2
Run options: --seed 34960 -n "/^(?:AVLogSubscriberTest#(?:test_render_inline_template)|ActionView::ClassMethodsTest#(?:test_additional_helper_classes_can_be_specified_as_in_a_controller)|ActionView::ControllerHelperMethod#(?:test_can_call_a_helper_method_defined_on_the_current_controller_from_a_helper)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance)|AtomFeedTest#(?:test_entry_should_only_use_published_if_created_at_is_present|test_entry_with_prefilled_options_should_use_those_instead_of_querying_the_record|test_feed_entry_type_option_default_to_text_html|test_feed_entry_type_option_specified|test_feed_entry_url_false_option_adds_no_link|test_feed_id_should_be_a_valid_tag|test_feed_should_include_atomPub_namespace|test_feed_should_include_two_entries|test_feed_should_use_default_language_if_none_is_given|test_feed_xhtml|test_feed_xml_processing_instructions|test_feed_xml_processing_instructions_duplicate_targets|test_providing_builder_to_atom_feed|test_self_url_should_default_to_current_request_url))$/"

# Running:

..................

Finished in 0.181423s, 99.2156 runs/s, 237.0152 assertions/s.
18 runs, 43 assertions, 0 failures, 0 errors, 0 skips
%

@yahonda
Copy link
Member Author

yahonda commented Mar 5, 2020

Based on undefined method root' for Rails:Module` error message, I'm wondering some of them are related to these errors:

require_relative "../../tools/test"

rails/tools/test.rb

Lines 14 to 20 in aeac2f5

class << Rails
# Necessary to get rerun-snippets working.
def root
@root ||= Pathname.new(COMPONENT_ROOT)
end
alias __root root
end

unless Rails.respond_to?(:root)
@defined_root = true
def Rails.root; :defined_root; end # Minitest `stub` expects the method to be defined.
end

@yahonda
Copy link
Member Author

yahonda commented Mar 10, 2020

According to the discussion on twitter, Here is the minimum steps to reproduce in Action View.

  • Steps to reproduce
% cd actionview
% PARALLEL_WORKERS=1 bin/test test/template/test_case_test.rb --seed 53708 -n "/^(?:ActionView::AssertionsTest#(?:test_uses_the_output_buffer_for_assert_select)|ActionView::AHelperWithInitializeTest#(?:test_the_helper\\'s_initialize_was_actually_called)|ActionView::ATestHelperTest#(?:test_named_routes_can_be_used_from_helper_included_in_view))$/"
  • Actual behavior
% PARALLEL_WORKERS=1 bin/test test/template/test_case_test.rb --seed 53708 -n "/^(?:ActionView::AssertionsTest#(?:test_uses_the_output_buffer_for_assert_select)|ActionView::AHelperWithInitializeTest#(?:test_the_helper\\'s_initialize_was_actually_called)|ActionView::ATestHelperTest#(?:test_named_routes_can_be_used_from_helper_included_in_view))$/"
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2
/Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2
Run options: --seed 53708 -n "/^(?:ActionView::AssertionsTest#(?:test_uses_the_output_buffer_for_assert_select)|ActionView::AHelperWithInitializeTest#(?:test_the_helper\\'s_initialize_was_actually_called)|ActionView::ATestHelperTest#(?:test_named_routes_can_be_used_from_helper_included_in_view))$/"

# Running:

..E

Error:
ActionView::ATestHelperTest#test_named_routes_can_be_used_from_helper_included_in_view:
ArgumentError: wrong number of arguments (given 3, expected 1)
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/routing/url_for.rb:108:in `initialize'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `new'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/rendering.rb:92:in `view_context'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/test_case.rb:212:in `view'
    /Users/yahonda/src/github.com/rails/rails/actionview/lib/action_view/test_case.rb:121:in `render'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/test_case_test.rb:273:in `block (2 levels) in <class:ATestHelperTest>'
    /Users/yahonda/src/github.com/rails/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:175:in `with_routing'
    /Users/yahonda/src/github.com/rails/rails/actionview/test/template/test_case_test.rb:265:in `block in <class:ATestHelperTest>'
    /Users/yahonda/src/github.com/rails/rails/railties/lib/rails/test_unit/line_filtering.rb:10:in `run'


bin/test test/template/test_case_test.rb:264



Finished in 0.050773s, 59.0865 runs/s, 59.0865 assertions/s.
3 runs, 3 assertions, 0 failures, 1 errors, 0 skips
%

yahonda added a commit to yahonda/rails that referenced this issue Mar 10, 2020
Follow up rails#38613 and rails#38094

Action View and Action Pack unit tests run in parallel by default
and the number of parallel workers is defined by `PARALLEL_WORKERS` value.

To investigate some random failures with SEED,
Disabling Parallel testing sometimes helps to isolate these failures.
@yahonda
Copy link
Member Author

yahonda commented Apr 11, 2020

Let me close this issue because the failures/errors at Action Text itself has been addressed by ruby/ruby@2943ff9d . Still "undefined method `root' for Rails:Module" exists at Action View, which should be addressed by Ruby code.

@yahonda yahonda closed this as completed Apr 11, 2020
@kaspth
Copy link
Contributor

kaspth commented Apr 11, 2020

🙌❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants