Implement connecting_to method
#40486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
add-method-to-set-specific-connection
branch
from
e3f45cf
to
386a06b
Compare
rafaelfranca
approved these changes
Oct 29, 2020
Sometimes you need to have a different default connection but aren't calling the connection with a block. An example is booting a console in `reading` mode. This adds the ability for a script to set a specific connection on boot while preserving the behavior of `connected_to` for application code.
eileencodes
force-pushed
the
add-method-to-set-specific-connection
branch
from
386a06b
to
231bcc7
Compare
|
Good call, I've updated the method name. 👍🏻 |
eileencodes
changed the title
connection_for methodconnecting_to method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have code at github that ensures the console is booted in readonly mode. I noticed there wasn't a public API for this so I added this method.
Sometimes you need to have a different default connection but aren't
calling the connection with a block. An example is booting a console in
readingmethod. This adds the ability for a script to set a specificconnection on boot while preserving the behavior of
connected_toforapplication code.
cc/ @rafaelfranca @seejohnrun @tenderlove @jhawthorn