Disable config.add_autoload_paths_to_load_path by default in Rails 7.1

[casperisfine]

Ref: 668673f

Now that Zeitwerk is the only autoloader, there no reason to add autoloaded paths to $LOAD_PATH (we should probably have done it in 7.0, but hey...).

@fxn let me know if it's good with you and I can merge.

[fxn]

Oh yes, let's do this.

One detail, it's a little secret that

which would cause reloading issues

is actually not the case due to a undocumented and experimental hack written for a different use case.

What we could say is that you just don't use require with autoloadable code, that is the whole point, just reference the constant.

[rafaelfranca]

Update the configuring guide 😂

[byroot]

Arf, everytime I miss one -_-

[casperisfine]

Actually it's already documented.

[rafaelfranca]

I mean document that in 7.1 the default will be false. But I guess we need to merge #44120 first.

[fxn]

I suppose, at some point we could just drop all this. Can't think of any use case for require + autoload path. The few that exist are covered with require_dependency.

[casperisfine]

Absolutely. We'll just have to leave it for at least 1 version, and maybe find a way to deprecate it?

[fxn]

👍

[yahonda]

As you may be already aware that, would you update these tests also?

cd railties
bin/test test/application/configuration_test.rb:1833 # test_autoload_paths_are_added_to_$LOAD_PATH_by_default 
bin/test test/application/configuration_test.rb:1872 # test_autoload_paths_can_be_set_in_the_config_file_of_the_environment
bin/test test/application/initializers/load_path_test.rb:24 # test_initializing_an_application_adds_the_application_paths_to_the_load_path
bin/test test/application/paths_test.rb:72 # test_load_path_includes_each_of_the_paths_in_config.paths_as_long_as_the_directories_exist

[byroot]

As you may be already aware

No, I'm just a big idiot. Sorry about that one... I'll fix it ASAP.