Add Object#in? support for open ranges #47316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
reviewed
Feb 8, 2023
| assert_not Date.today.in?(..Date.yesterday) | ||
|
|
||
| # This never returns in Ruby 3.1 | ||
| Timeout.timeout(0.1) { assert_not Date.today.in?(Date.tomorrow..) } |
There was a problem hiding this comment.
I think we can remove this assertion. We don't need to test all the behavior of cover?. This will avoid the need for this test to wait at least 0.1s to finish.
There was a problem hiding this comment.
Sounds good, also,is no longer necessary for 3.1, I had it before introducing cover in Object#in? change for the test to fail fast.
There was a problem hiding this comment.
Removed the timeout from last assertion, kept that specific assertion as it was the one with worst outcome (not returning in Ruby 3.1), also reworded the method documentation a bit.
joiggama
force-pushed
the
activesupport-object-in-support-open-ranges
branch
3 times, most recently
from
eb8931a
to
264905b
Compare
This leverages Range#cover? to properly handle beginless and endless range inclusion checks.
joiggama
force-pushed
the
activesupport-object-in-support-open-ranges
branch
from
264905b
to
47b0aa0
Compare
carlosantoniodasilva
added a commit
to carlosantoniodasilva/rails
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #47272
Detail
This Pull Request changes
Object#in?behavior to properly handle open date ranges i.e. beginless and endless ranges.e.g. Date.today.in?(Date.tomorrow..) => false
Additional information
This leverages
Range#cover?to properly handle beginless and endlessdate range inclusion checks.
Current behavior in Ruby 3.1 is that method never returns, whereas Ruby 3.2 raises a
TypeError:Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]