Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-grid not supported. #395

Closed
ycrepeau opened this issue Mar 28, 2017 · 8 comments
Closed

CSS-grid not supported. #395

ycrepeau opened this issue Mar 28, 2017 · 8 comments

Comments

@ycrepeau
Copy link

See: sass/sass#2233

Summary: With the release of FF52 and GC57, CSS-grid layout is now supported. With this new feature, construct like grid-template-columns: repeat(5, 1fr) are present.

The CSS function 'repeat' is not really supported by SASS.

Solution: The last version of SASS (3.5) addresses the issue.

@rafaelfranca
Copy link
Member

sass 3.5 is already supported by this gem https://github.com/rails/sass-rails/blob/v5.0.6/sass-rails.gemspec#L17, so why it is not supported?

@ycrepeau
Copy link
Author

It works perfectly well in development mode.

It fails only in production environment with rake asset:precompile (aka heroku deploy).

@rafaelfranca
Copy link
Member

If it works in development and not in production with the same set of gems I recommend you to report the issue to your production environment since it seems to be related with it.

sass-rails supports sass 3.5 and if it is fixed in sass 3.5 so you should be able to get it installed. If the issue is not fixed in sass 3.5, you should report the issue in the sass repository since sass-rails is just a wrapper around sass.

@ycrepeau
Copy link
Author

I have the error locally when I run:

RAILS_ENV=production bundle exec rake assets:precompile

So, the problem starts here (locally) when I test my local environment in production mode.

@rafaelfranca
Copy link
Member

Can you please provide a sample application that reproduces the error?

@caiotarifa
Copy link

caiotarifa commented Mar 30, 2017

@rafaelfranca, I'm having a similar error using @supports.

Just try:

.header {
  backdrop-filter: saturate(180%) blur(20px);
  background-color: rgba(#fff, 0.975);

  @supports (backdrop-filter: blur()) {
    background-color: rgba(#fff, 0.8);
  }
}

It works on development, but not in production.


The version of sass-rails is 5.0.6.

@rafaelfranca
Copy link
Member

sass-rails doesn't defines the sass behavior, the gem responsible for this is sass, if it is working in development and not production either it is a problem in sass or the production envrionment.

@jdolle
Copy link

jdolle commented Jun 23, 2017

Sass added support sass/sass#2233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants