Expire more for larger writes #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expiries should be proportional to the number of items written, not the number of write operations. We multiply the number of writes by the expiry chance to determine how many expiries to trigger. We trigger an expiry for every whole number in that muliplied value and determine whether to trigger an extra expiry based on the remainder.
djmb
force-pushed
the
cache-expiry-overflow
branch
from
e05fea6
to
64bb6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expiries should be proportional to the number of items written, not the number of write operations.
We multiply the number of writes by the expiry chance to determine how many expiries to trigger. We trigger an expiry for every whole number in that muliplied value and determine whether to trigger an extra expiry based on the remainder.