uninitialized constant Spring::SID::DL #274

teoljungberg · 2014-03-14T23:01:40Z

Spring version: 1.12
Ruby version 1.9.3-p545

What more info can I provide?

/Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/sid.rb:17:in `fiddle_func': uninitialized constant Spring::SID::DL (NameError)
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/sid.rb:30:in `sid'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/sid.rb:39:in `pgid'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/server.rb:78:in `set_pgid'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/server.rb:34:in `boot'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/server.rb:14:in `boot'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/run.rb:36:in `block in boot_server'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/run.rb:34:in `fork'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/run.rb:34:in `boot_server'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/run.rb:18:in `call'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/command.rb:7:in `call'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/rails.rb:23:in `call'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client/command.rb:7:in `call'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/lib/spring/client.rb:26:in `run'
        from /Users/teo/.rbenv/versions/1.9.3-p545/lib/ruby/gems/1.9.1/gems/spring-1.1.2/bin/spring:48:in `<top (required)>'
        from /Users/teo/.rbenv/versions/1.9.3-p545/bin/spring:23:in `load'
        from /Users/teo/.rbenv/versions/1.9.3-p545/bin/spring:23:in `<main>'

CyborgMaster · 2014-03-18T16:54:40Z

I just had a coworker set up a new mac and he ran into this error. It happened when he compiled ruby (via RVM) using clang, but didn't happen when ruby was compiled with apple-gcc42. Does spring support compilation with clang?

benmoss · 2014-03-24T19:32:18Z

I am getting this too, on spring 1.1.1

tombeynon · 2014-03-25T10:12:22Z

Same. This only started occurring after upgrading to Ruby 1.9.3-p545

teoljungberg · 2014-03-26T08:31:22Z

I have the same issue on Ruby 1.9.3-p484 which has worked for me in the past

viniciusoyama · 2014-03-29T19:47:17Z

Same.
OSX 10.9, Ruby 1.9.3-p545 compiled with RVM and CLANG.
Spring 1.1.2

taiki-t · 2014-04-03T04:39:01Z

Same. In my case changing the compiler to apple-gcc42 from clang solved the problem as CyborgMaster said. Thank you.

OSX 10.9
Ruby 1.9.3-p484
rbenv

viniciusoyama · 2014-04-03T13:11:31Z

Im my case changing the compiler to gcc46 solved the problem too. The problem is that when you compile using CLAN it doens't include the dynamic libraries. So when you try to use them with: "Spring::SID::DL" it doens't work.

pigoz · 2014-04-09T08:26:10Z

The problem is fiddle_func in sid.rb is called regardless of the fact that DL is defined, while it should probably shell out if it's not (instead of crashing). I can prepare a patch if that's ok.

jonleighton · 2014-04-09T21:30:38Z

Does require 'dl' (in irb) work for any of you folks? I'm wondering if it's just a missing require.

I think @pigoz's suggestion is good either way though - please do prepare a patch.

viniciusoyama · 2014-04-09T21:38:46Z

@jonleighton
It works when I compile the ruby 1.9.3 using gcc46. But when I use CLANG it doesn't work.
If you are using OSX you can instal using homebrew:
brew install gcc46
(wait 2 or 3 hours haha)
and then try
rvm reinstall 1.9.3

teoljungberg · 2014-04-10T08:05:07Z

@jonleighton require'ing dl didn't help, it throws an error in irb

When compiling Ruby 1.9.3 with clang, Fiddle is compiled in while DL is not. This commit fixes an usage of the DL module in the case it's not compiled in. Unfortunately Fiddle::Handle and Fiddle.dlopen were only added in Ruby 2, but a dlopen call (available as part of the DL module) is needed to use Fiddle::Function. Fixes rails#274

pigoz · 2014-04-10T21:26:25Z

See above commit, I am a little unsure if this actually solves the problem completely, since the code that shells out actually returns always 0 in my irb. Here's an example with Ruby 2:

irb(main):004:0> Process.getsid
=> 319
irb(main):005:0> `ps -p #{Process.pid} -o sess=`.to_i
=> 0

This is probably an OS X only issue though.

caius · 2014-04-11T09:27:19Z

I've just worked around this locally by recompiling my ruby using a patch from the FreeBSD lists, changing the compile flags for dl if clang is being used.

Used with ruby-install and my spring is happily bouncing along again (I put the patch in a gist to use: https://gist.github.com/caius/10452604):

$ ruby-install -p https://gist.githubusercontent.com/caius/10452604/raw/acd421a8461f4d776a8f752663db19e321f850e0/ext_dl_extconf_rb.patch ruby 1.9.3-p545
# <snip>
>>> Successfully installed ruby 1.9.3-p545 into /Users/caius/.rubies/ruby-1.9.3-p545

$ spring status
Spring is not running.

$ spring rails console
Loading development environment (Rails 3.2.16)
1.9.3 (main):0 >

caius · 2014-04-11T09:31:12Z

@pigoz I'm also seeing the same behaviour from shelling out to ps to get the session id and it being zero. I see the same behaviour for other non-ruby processes on OS X too:

$ ps -p $(pgrep ssh-agent) -o sess=
     0

jonleighton · 2014-04-15T21:47:19Z

Hmm, I've no idea why the ps command isn't working on OS X...

maxime-d · 2014-04-16T09:39:17Z

Same.
OSX 10.9.2, Ruby 1.9.3-p545 compiled with rbenv
Spring 1.1.2

I have resolved the problem compiling ruby with apple-gcc42.

boxofrad · 2014-05-07T14:06:35Z

Same error on 1.9.3-p429 after reinstalling following upgrade to mavericks, with rbenv

sobrinho · 2014-05-23T16:45:47Z

Same error here, OS X, ruby 1.9.3-p545 using rbenv and ruby-build.

sobrinho · 2014-05-23T16:46:06Z

Although it works on ruby 2.1.1.

calebx · 2014-05-29T04:28:32Z

Same error here, OS X, ruby 1.9.3-p545 using rbenv and ruby-build.
wtf...
i had try changing cc to gcc-4.6, and to gcc-4.2, both double times, all failed...

kastman · 2014-06-25T04:01:00Z

ruby 1.9.3-p547 using rbenv and ruby-build also still fails currently

jfairchild · 2014-06-27T18:34:51Z

spring version 1.1.3, ruby 1.9.3-p545, and using compiler /opt/boxen/homebrew/bin/gcc-4.2
still fails.

konyu · 2014-07-16T01:32:25Z

I got same bug.
OSX 10.9.4,
spring version 1.1.3,
ruby 1.9.3-p545(compile gcc-4.2)

Could you tell me what should I write more informations of my env?

teoljungberg · 2014-07-16T07:52:51Z

I just tried out @pigoz patch and it works just fine on 1.9. I also tested against 2.1.2 to be safe.
@jonleighton Is it mergable into master?

pigoz · 2014-07-16T08:23:02Z

I think it's better for you to compile Ruby with the FreeBSD patch posted by @caius (it's a one line patch)

JezC · 2014-07-25T06:58:28Z

It's not just the use of clang, I think. Testing against various rubies that I have:

1.9.3-p0 - requires gcc - untested
1.9.3-p125 - first llvm version, spring works.
1.9.3-p547 - latest stable, spring fails
2.0.0-p481 - spring works
2.1.2-p95 - latest stable, spring is fine

From other reports, Spring works on later patch levels of 1.9.3, if using gcc. But it worked, at some point, on llvm on 1.9.3. And it now works on llvm with the latest stable ruby (2.1.2p95), and has worked on 2.0.0 at least at the most recent stable. There appears to be some range of 1.9.3 including the most recent stable, perhaps of other ruby patch levels, that fails.

Context: Mac OS X 10.9.4, Xcode 5.1.1, spring 1.1.3

jgeiger · 2014-10-21T16:14:30Z

I found this fix on someone else branch and it seems github let me make a pull request from their branch to here. I didn't write the code, but I've used it, and it works quite well. It would solve this problem without making people jump though hoops.

pigoz · 2014-10-21T16:36:02Z

@jgeiger I wrote that but we were unsure about using it because OS X bugs in ps :) See this comment for reference #274 (comment)

jgeiger · 2014-10-21T16:39:16Z

Ah. It might be working for me and what I need, but not 100%. Thanks.

jonleighton added the bug label Jul 7, 2014

jgeiger mentioned this issue Oct 21, 2014

Fix usage of uninitialized ::DL in Ruby 1.9.3 #357

Merged

jonleighton closed this as completed in #357 Nov 15, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uninitialized constant Spring::SID::DL #274

uninitialized constant Spring::SID::DL #274

teoljungberg commented Mar 14, 2014

CyborgMaster commented Mar 18, 2014

benmoss commented Mar 24, 2014

tombeynon commented Mar 25, 2014

teoljungberg commented Mar 26, 2014

viniciusoyama commented Mar 29, 2014

taiki-t commented Apr 3, 2014

viniciusoyama commented Apr 3, 2014

pigoz commented Apr 9, 2014

jonleighton commented Apr 9, 2014

viniciusoyama commented Apr 9, 2014

teoljungberg commented Apr 10, 2014

pigoz commented Apr 10, 2014

caius commented Apr 11, 2014

caius commented Apr 11, 2014

jonleighton commented Apr 15, 2014

maxime-d commented Apr 16, 2014

boxofrad commented May 7, 2014

sobrinho commented May 23, 2014

sobrinho commented May 23, 2014

calebx commented May 29, 2014

kastman commented Jun 25, 2014

jfairchild commented Jun 27, 2014

konyu commented Jul 16, 2014

teoljungberg commented Jul 16, 2014

pigoz commented Jul 16, 2014

JezC commented Jul 25, 2014

jgeiger commented Oct 21, 2014

pigoz commented Oct 21, 2014

jgeiger commented Oct 21, 2014

uninitialized constant Spring::SID::DL #274

uninitialized constant Spring::SID::DL #274

Comments

teoljungberg commented Mar 14, 2014

CyborgMaster commented Mar 18, 2014

benmoss commented Mar 24, 2014

tombeynon commented Mar 25, 2014

teoljungberg commented Mar 26, 2014

viniciusoyama commented Mar 29, 2014

taiki-t commented Apr 3, 2014

viniciusoyama commented Apr 3, 2014

pigoz commented Apr 9, 2014

jonleighton commented Apr 9, 2014

viniciusoyama commented Apr 9, 2014

teoljungberg commented Apr 10, 2014

pigoz commented Apr 10, 2014

caius commented Apr 11, 2014

caius commented Apr 11, 2014

jonleighton commented Apr 15, 2014

maxime-d commented Apr 16, 2014

boxofrad commented May 7, 2014

sobrinho commented May 23, 2014

sobrinho commented May 23, 2014

calebx commented May 29, 2014

kastman commented Jun 25, 2014

jfairchild commented Jun 27, 2014

konyu commented Jul 16, 2014

teoljungberg commented Jul 16, 2014

pigoz commented Jul 16, 2014

JezC commented Jul 25, 2014

jgeiger commented Oct 21, 2014

pigoz commented Oct 21, 2014

jgeiger commented Oct 21, 2014