Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't watch any files outside the app root #75

Closed
jonleighton opened this issue Feb 22, 2013 · 1 comment
Closed

Don't watch any files outside the app root #75

jonleighton opened this issue Feb 22, 2013 · 1 comment
Milestone

Comments

@jonleighton
Copy link
Member

This seemed like a nice idea at the time but it means we're watching lots more files than just those under the app root, so using more CPU and I think it's simpler to just say "spring will only notice changes under your app root". If you change e.g. a gem which resides on the filesystem then you'll need to stop spring to notice the changes.

@rwjblue
Copy link
Contributor

rwjblue commented Feb 24, 2013

This could be wrapped up in the changes to ApplicationWatcher to add polling.

Most of the external polling libraries (rb-inotify and rb-fsevent) only support watching directories as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants