Stop depending on Set #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
drop-set-dependency
branch
from
128b23f
to
35f03bb
Compare
lib/spring/application.rb
Outdated
| @@ -181,7 +181,7 @@ def serve(client) | |||
| pid = fork { | |||
| # Make sure to close other clients otherwise their graceful termination | |||
| # will be impossible due to reference from this fork. | |||
| @clients.select { |c| c != client }.each(&:close) | |||
| @clients.each_key { |c| c.clonse if c != client } | |||
There was a problem hiding this comment.
Suggested change
| @clients.each_key { |c| c.clonse if c != client } | |
| @clients.each_key { |c| c.close if c != client } |
casperisfine
force-pushed
the
drop-set-dependency
branch
from
35f03bb
to
b0fd647
Compare
It is now a gem, and since spring load before bundler if you have multiple `set` versions installed, you might load the wrong one causing already defined constant warnings.
casperisfine
force-pushed
the
drop-set-dependency
branch
from
b0fd647
to
7f4ddf9
Compare
|
cc @rafaelfranca, this isn't a big bug as it's still very rare to have |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now a gem, and since spring load before bundler if you have multiple
setversions installed, you might load the wrong one causing already defined constant warnings.Initially wrongly reported as a bundler issue: rubygems/rubygems#5127
Reported to be my @Bowman-42