Respect config.digest = false for asset_path
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `asset_path` internals only respected the `:digest` option, but ignored the global config setting. This meant that `config.digest = false` could not be used in conjunction with `config.compile = false` this corrects the behavior.
|
Duplicate of rails/rails#7672 |
|
Same changes as requested here: rails/rails#7647. However, we get a new test failure here https://github.com/wagenet/sprockets-rails/blob/asset_path_digest_fix/test/assets_test.rb#L256. I'm not sure what the correct solution is. |
guilleiguaran
added a commit
that referenced
this pull request
Sep 21, 2012
Respect `config.digest = false` for `asset_path`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
asset_pathinternals only respected the:digestoption,but ignored the global config setting. This meant that
config.digest = falsecould not be used in conjunction withconfig.compile = falsethis corrects the behavior.