Merge pull request #670 from zinsbaustein/fix-coffee-processor-caching

Fix cache key for coffee script processor

CHANGELOG.md

@@ -16,6 +16,7 @@ Get upgrade notes from Sprockets 3.x to 4.x at https://github.com/rails/sprocket
 - Allow assets already fingerprinted to be served through `Sprockets::Server`
 - Do not fingerprint files that already contain a valid digest in their name
 - Remove remaining support for Ruby < 2.4.[#672](https://github.com/rails/sprockets/pull/672)
+- Fix cache key for coffee script processor to be dependent on the filename [#670](https://github.com/rails/sprockets/pull/670)
 
 ## 4.0.2
 

lib/sprockets/coffee_script_processor.rb

@@ -20,7 +20,7 @@ def self.cache_key
     def self.call(input)
       data = input[:data]
 
-      js, map = input[:cache].fetch([self.cache_key, data]) do
+      js, map = input[:cache].fetch([self.cache_key, data, input[:filename]]) do
         result = Autoload::CoffeeScript.compile(
           data,
           sourceMap: "v3",

test/test_coffee_script_processor.rb

@@ -28,6 +28,26 @@ def test_compile_coffee_script_template_to_js
     assert_equal ["squared.source.coffee"], result[:map]["sources"]
   end
 
+  def test_changing_map_sources_for_files_with_same_content
+    input = {
+      load_path: File.expand_path("../fixtures", __FILE__),
+      filename: File.expand_path("../fixtures/squared.coffee", __FILE__),
+      content_type: 'application/javascript',
+      environment: @env,
+      data: "square = (n) -> n * n",
+      name: 'squared',
+      cache: Sprockets::Cache.new,
+      metadata: { mapping: [] }
+    }
+    result = Sprockets::CoffeeScriptProcessor.call(input)
+    assert_equal ["squared.source.coffee"], result[:map]["sources"]
+
+    input[:filename] = File.expand_path("../fixtures/peterpan.coffee", __FILE__)
+
+    result = Sprockets::CoffeeScriptProcessor.call(input)
+    assert_equal ["peterpan.source.coffee"], result[:map]["sources"]
+  end
+
   def test_cache_key
     assert Sprockets::CoffeeScriptProcessor.cache_key
   end