Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environment version affect digest of assets with no preprocessor #680

Closed

Conversation

rafbm
Copy link
Contributor

@rafbm rafbm commented Jun 3, 2020

Disclaimer: I did this pretty quickly with no prior knowledge of Sprockets internals.

I followed the logic of #404 and created an equivalent test in test_environment.rb using "blank.gif" instead of "gallery.js", which was failing. Then I realized that PR clearly covered the if processors.any? branch only and not the else. I implemented what seemed to be the closest and most inoffensive change (doesn’t affect the implementation of file_digest or similar), which got my test to pass. Then I blindly fixed the failing tests in test_asset.rb, and here we are.

@rafaelfranca
Copy link
Member

This was closed by 5038ad5. I just applied your test in 7f64817 to make sure it was fixed.

@rafbm
Copy link
Contributor Author

rafbm commented Jun 5, 2020

Awesome! Thanks much.

@rafbm rafbm deleted the version-affects-digest-no-preprocessor branch June 5, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants