Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub actions #709

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

hahmed
Copy link
Contributor

@hahmed hahmed commented Jun 14, 2021

what

Move over to GitHub actions similar to other repos in rails.

I ended up dropping the notifications to campfire/irc.freenode.org#rails-contrib, but i'm wondering if that's still needed?

I have added 3 GitHub actions;

  • ci.yml: run ruby 2.5-3.0, jruby + jruby head (allow failures), ruby head (allow failures)
  • isolated.yml to run the isolated tests rake task
  • rubocop yaml file

anything else

We are still running ruby 2.5 tests because sprockets is still supporting ruby 2.5. Maybe we need to bump the ruby version, because ruby 2.5 is EOL?

@hahmed hahmed force-pushed the ha/move-to-github-actions branch from e261c6a to bc46315 Compare June 14, 2021 23:19
@hahmed hahmed marked this pull request as ready for review June 14, 2021 23:28
@hahmed hahmed force-pushed the ha/move-to-github-actions branch 2 times, most recently from 01cefe5 to 769cd3a Compare June 15, 2021 08:15
CHANGELOG.md Outdated Show resolved Hide resolved
@hahmed hahmed force-pushed the ha/move-to-github-actions branch from 6307121 to 5471e5d Compare June 17, 2021 21:14
@hahmed hahmed force-pushed the ha/move-to-github-actions branch from 5471e5d to 73552d3 Compare June 17, 2021 21:15
@rafaelfranca rafaelfranca merged commit d7cd811 into rails:master Jun 17, 2021
@hahmed hahmed deleted the ha/move-to-github-actions branch June 17, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants