Adds additional condition to PathUtils#split_subpath to avoid undefined error method for 'start_with?' #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddink
force-pushed
the
fix/path_utils_split_subpath/undefined_method_error
branch
3 times, most recently
from
5b3ee3f
to
fb76fd0
Compare
…ed method error for 'start_with?'
ddink
force-pushed
the
fix/path_utils_split_subpath/undefined_method_error
branch
from
fb76fd0
to
dad2733
Compare
|
How is subpath nil? I don't see any place in the sprockets code that would cause that. Can you provide a way to reproduce the error? |
|
Closed by #684. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into an undefined error method for 'start_with?' on line 60 of lib/sprockets/path_utils.rb. While running rspec I've received about 80 failures mentioning this error. I found that I could avoid the error with an additional condition that checks whether or not the
subpathargument is present.By no means am I sure this is the proper solution, but this is working for our application at the moment.