Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v3.x] Make Sprockets::Utils.module_include thread safe on JRuby #760

Closed
wants to merge 1 commit into from
Closed

[backport/v3.x] Make Sprockets::Utils.module_include thread safe on JRuby #760

wants to merge 1 commit into from

Conversation

chadlwilson
Copy link
Contributor

Backport/cherrypick of #759 to 3.x

Justification for requesting backport

  • Backport seems relatively simple, as this code is large unchanged and module_include appears to be used in the same way on 3.x and 4.x
  • The breaking changes in Sprockets 4 (manifest.js and friends) have made migration challenging for some folks (as well as the changes folks needed to get to Rails 6.0/6.1 to even unblock Sprockets upgrade)
  • Some wrapping libraries such as Middleman appear to have some challenges with various combinations of sprockets/middleman/sass/sassc versions. Having this particular issue fixed on 3.x sprockets allows some decoupling of these various upgrades without experiencing issues during live reloads as described in cannot load such file -- sass聽sass/sassc-rails#114 (yes, sassc and sassc-rails are also deprecated, but bridging support to dart sass is available in https://github.com/ntkme/sassc-embedded-shim-ruby)
    • Use of sass-embedded as opposed to sass-rails appears to increase the chance of triggering the concurrency issue this addresses

If this isn't something that will be considered for release, please feel free to note and close this PR 馃檹

@chadlwilson
Copy link
Contributor Author

Closing this given the lack of build automation support for 3.x releases. Since then I have successfully migrated my use case to Sprockets 4.

@chadlwilson chadlwilson closed this Oct 4, 2022
@chadlwilson chadlwilson deleted the backport-module-loading-mutex branch October 4, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants