This repository has been archived by the owner on Aug 17, 2017. It is now read-only.
Correct readme migration path instructions #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the extra steps added to the readme in this commit, the migration to Rails 4 instructions will cause ActiveModel::MassAssignmentSecurity::Error to be raised on any model that has had necessary attr_accessible declarations removed (as the instructions direct), because `config.active_record.whitelist_attributes = true` in config/application.rb, which is the default setting, requires all models to whitelist mass-assigned attributes. The extra steps added to the readme in this commit make it possible to update and deploy one model at a time, which is valuable. I'm not very familiar with this, but it appears that attr_protected works because it signals that the model secures mass assignment with a blacklist, and then an empty black list makes all attributes accessible and leaves the responsibility of mass assignment protection to strong_parameters. More info: http://stackoverflow.com/a/14252971/724752 #226 An alternative to this commit might be to just put an `attr_protected` with no arguments in ActiveModel::ForbiddenAttributesProtection, but I'm not ready to investigate that now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the extra steps added to the readme in this commit, the migration to Rails 4 instructions will cause ActiveModel::MassAssignmentSecurity::Error to be raised on any model that has had necessary attr_accessible declarations removed (as the instructions direct), because
config.active_record.whitelist_attributes = truein config/application.rb, which is the default setting, requires all models to whitelist mass-assigned attributes.The extra steps added to the readme in this commit make it possible to update and deploy one model at a time, which is valuable.
I'm not very familiar with this, but it appears that attr_protected works because it signals that the model secures mass assignment with a blacklist, and then an empty black list makes all attributes accessible and leaves the responsibility of mass assignment protection to strong_parameters.
More info:
http://stackoverflow.com/a/14252971/724752
#226
An alternative to this commit might be to just put an
attr_protectedwith no arguments in ActiveModel::ForbiddenAttributesProtection, but I'm not ready to investigate that now.