Allow users to override scaffold generator templates #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
164-flavorjones-override-erb-templates
branch
from
b527209
to
fd7e0c4
Compare
dixpac
reviewed
Jan 8, 2024
dixpac
reviewed
Jan 8, 2024
|
Works great with scaffolds. |
|
@dixpac Yeah, I was hoping nobody would care about overriding those. 😆 😭 You're right, while I'm here I might as well add mailer and controller. Thanks for the review! |
and set Rails::Generators.templates_path to include it before the generator classes are instantiated so that the local 'lib/templates' directory is part of the generators' `source_paths`. Also see railties/lib/rails/generators/base.rb and `Rails::Generators::Base.inherited`
Note that developers can override by placing templates in either:
- lib/templates/tailwindcss/{scaffold,mailer,controller}
- lib/templates/erb/{scaffold,mailer,controller}
flavorjones
force-pushed
the
164-flavorjones-override-erb-templates
branch
from
fd7e0c4
to
85c2c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported at #164
I think this PR is preferable to #247 because it has tests and is a simpler fix.
Note that in order to test this, the test suite now uses the same temporary directory for all tests, so we are then able to set
Rails::Generators.templates_pathbefore the generator classes are instantiated.cc @dixpac