Increase form input field border contrast #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contrast provided by the border-gray-200 Tailwind utility class is very poor. It's nearly impossible to distinguish the edges of an input field on a white background. That's not a great default experience for Rails scaffolds. With a slight bump to border-gray-400, things are much easier to distinguish.
|
Looks better, thank you! I think this is a better default. For what it's worth, it matches what Tailwind uses in their Forms examples. |
flavorjones
approved these changes
May 1, 2024
dhh
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contrast provided by the
border-gray-200Tailwind utility class is very poor. It's nearly impossible to distinguish the edges of an input field on a white background.That's not a great default experience for Rails scaffolds.
With a slight bump to
border-gray-400, things are much easier to distinguish.Here's a simple example where I only changed the border class on the
Namefield at the top:Safari:
Firefox:
Chrome:
With a stock Rails 7.1 app, I genuinely could not distinguish the edges of any input field until I made this change. I think the examples speak for themselves. I can understand the desire for subtlety but I think this change would be beneficial. I'm deliberately not address a similar issue with non-call-to-action buttons in this PR, in case there's disagreement.