Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate safe_level of ERB.new in Ruby 2.6 #594

Merged
merged 1 commit into from Apr 18, 2018
Merged

Deprecate safe_level of ERB.new in Ruby 2.6 #594

merged 1 commit into from Apr 18, 2018

Commits on Apr 12, 2018

  1. Deprecate safe_level of ERB.new in Ruby 2.6 

    The interface of `ERB.new` will change from Ruby 2.6.

> Add :trim_mode and :eoutvar keyword arguments to ERB.new.
> Now non-keyword arguments other than first one are softly deprecated
> and will be removed when Ruby 2.5 becomes EOL. [Feature #14256]

https://github.com/ruby/ruby/blob/2311087b685e8dc0f21f4a89875f25c22f5c39a9/NEWS#stdlib-updates-outstanding-ones-only

The following address is related Ruby's commit.
ruby/ruby@cc777d0

This PR uses `ERB.version` to switch `ERB.new` interface. Because
Thor supports multiple Ruby versions, it need to use the appropriate interface.

Using `ERB.version` instead of `RUBY_VERSON` is based on the following patch.
ruby/ruby#1826

This patch is built into Ruby.
ruby/ruby@40db89c
    @koic
    koic committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    70021d0 View commit details
    Browse the repository at this point in the history