Lock scroll bottom on console window resize. Fixes #32. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On resizer mousedown, save the current scroll position. On resizer mousemove calculate the change and adjust the scroll position. This allows the current scroll position to lock to the bottom of the screen when rezizing the console window. Tested on the latest chrome, firefox and safari.
|
Thanks Noah, Can you post a gif of the before/after the PR? I can't seem to remember this issue and trying it out locally, can't spot the difference with the current JS we have. |
beforeafter |
|
🙇 |
gsamokovarov
added a commit
that referenced
this pull request
Feb 1, 2015
Lock scroll bottom on console window resize. Fixes #32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On resizer mousedown, save the current scroll position. On resizer mousemove
calculate the change and adjust the scroll position. This allows the current
scroll position to lock to the bottom of the screen when resizing the console
window. Tested on the latest chrome, firefox and safari.