Use alias_method instead of alias_method_chain #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jonatack, thank you for the PR. Can we go with two |
|
Got it. |
since alias_method_chain is deprecated now in Rails master targeting 5.0.0. Use alias_method instead of alias_method_chain since alias_method_chain is deprecated now in Rails master targeting 5.0.0.
jonatack
force-pushed
the
use-prepend-instead-of-alias-method-chain
branch
from
2b8a74a
to
71ca0cb
Compare
|
Updated and squashed. |
jonatack
changed the title
|
Thanks! |
gsamokovarov
added a commit
that referenced
this pull request
Apr 2, 2015
…thod-chain Use alias_method instead of alias_method_chain
|
Thank you! The original PR using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not an ideal implementation, but the idea is to get the ball rolling on upgrading to Module#prepend, since
alias_method_chainis deprecated in Rails 5.0.A simpler migration path would be to replace alias_method_chain with two
alias_methods.
WDYT?